[Bug 1740] hashlimit limit: reduction to lowest terms in the output is confusing

[bugzilla-daemon at netfilter.org]

https://bugzilla.netfilter.org/show_bug.cgi?id=1740

--- Comment #3 from Phil Sutter <phil at nwl.cc> ---
(In reply to Fabio from comment #2)
> Just want to add that it won't need extra data, but it could just check the
> htable-expire value:
> 
> 86400000 -> report it in units/day (and avoid printing the htable-expire)
> 3600000 -> report it in units/hour (and avoid printing the htable-expire)
> 60000 -> report it in units/minute (and avoid printing the htable-expire)

Yes, htable-expire defaults to the given unit * 1000. Though it may be
specified explicitly, so extra checks are probably needed, at least a test for
"expire == unit * 1000". But this in turn may match by chance and cause
unexpected formatting of the rate value.

> Anyway I can agree with you, if it adds complexity (extra data or not) maybe
> it's not worth.

I am against changing this if it's doable given the data the kernel presents
already. Adding a new match revision is the kind of overhead I want to avoid.
So if you see a solution to the above, feel free to reopen this ticket!

Thanks, Phil

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20240409/5ba29113/attachment.html>