<html>
<head>
<base href="https://bugzilla.netfilter.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED WONTFIX - hashlimit limit: reduction to lowest terms in the output is confusing"
href="https://bugzilla.netfilter.org/show_bug.cgi?id=1740#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED WONTFIX - hashlimit limit: reduction to lowest terms in the output is confusing"
href="https://bugzilla.netfilter.org/show_bug.cgi?id=1740">bug 1740</a>
from <span class="vcard"><a class="email" href="mailto:phil@nwl.cc" title="Phil Sutter <phil@nwl.cc>"> <span class="fn">Phil Sutter</span></a>
</span></b>
<pre>(In reply to Fabio from <a href="show_bug.cgi?id=1740#c2">comment #2</a>)
<span class="quote">> Just want to add that it won't need extra data, but it could just check the
> htable-expire value:
>
> 86400000 -> report it in units/day (and avoid printing the htable-expire)
> 3600000 -> report it in units/hour (and avoid printing the htable-expire)
> 60000 -> report it in units/minute (and avoid printing the htable-expire)</span >
Yes, htable-expire defaults to the given unit * 1000. Though it may be
specified explicitly, so extra checks are probably needed, at least a test for
"expire == unit * 1000". But this in turn may match by chance and cause
unexpected formatting of the rate value.
<span class="quote">> Anyway I can agree with you, if it adds complexity (extra data or not) maybe
> it's not worth.</span >
I am against changing this if it's doable given the data the kernel presents
already. Adding a new match revision is the kind of overhead I want to avoid.
So if you see a solution to the above, feel free to reopen this ticket!
Thanks, Phil</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are watching all bug changes.</li>
</ul>
</body>
</html>