[Bug 836] New: ipset_parse_elem is declared/defined with wrong parameter type

bugzilla-daemon at netfilter.org bugzilla-daemon at netfilter.org
Sun Jul 28 02:25:54 CEST 2013


https://bugzilla.netfilter.org/show_bug.cgi?id=836

           Summary: ipset_parse_elem is declared/defined with wrong
                    parameter type
           Product: ipset
           Version: unspecified
          Platform: x86_64
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: default
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: quentin at armitage.org.uk
   Estimated Hours: 0.0


Created attachment 408
  --> https://bugzilla.netfilter.org/attachment.cgi?id=408
Patch to change 2nd parameter type of ipset_parse_elem

The only place in ipset where ipset_parse_elem is called is src/ipset.c. The
second parameter to the function call is type->last_elem_optional, which is of
type bool, but ipset_parse_elem is defined in lib/parse.c with the second
parameter having type enum ipset_opt.

The use in lib/parse.c is clearly as a bool.

A patch is attached.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the netfilter-buglog mailing list