[Bug 838] ipset add foo syslog fails for bitmap:port

[bugzilla-daemon at netfilter.org]

https://bugzilla.netfilter.org/show_bug.cgi?id=838

Quentin Armitage <quentin at armitage.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #409 is|0                           |1
           obsolete|                            |

--- Comment #3 from Quentin Armitage <quentin at armitage.org.uk> 2013-08-09 13:42:16 CEST ---
Created attachment 411
  --> https://bugzilla.netfilter.org/attachment.cgi?id=411
Updated patch to allow UDP service names to be specified for bitmap:port

I have added the function ipset_parse_tcp_udp_port in line with your
suggestion. I don't think the function name I have chosen is a good choice
since there is already a function ipset_parse_tcpudp_port, and the new name is
just confusing with the other name. However I couldn't think of a better name
that matched the existing function name scheme, so you may want to change the
name I have used.

Without IPSET_OPT_PROTO I am getting the following error messages:

# ipset add foo udp:syslog
ipset v6.19: There are not allowed options (26) but can't resolve them. It's a
bug, please report the problem.

# ipset del foo udp:syslog
ipset v6.19: There are not allowed options (26) but option list is NULL. It's a
bug, please report the problem.

# ipset test foo udp:syslog
ipset v6.19: There are not allowed options (26) but option list is NULL. It's a
bug, please report the problem.

I have removed IPSET_OPT_PROTO from create though, since that isn't required.

I couldn't see a way of getting it to work without IPSET_OPT_PROTO being
specified, so in order to stop the protocol option being passed to the kernel,
I have added:
ipset_data_flags_unset(data, IPSET_FLAG(IPSET_OPT_PROTO));
in the new function ipset_parse_tcp_udp_port.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.