[Bug 838] ipset add foo syslog fails for bitmap:port

bugzilla-daemon at netfilter.org bugzilla-daemon at netfilter.org
Wed Aug 7 23:54:55 CEST 2013


https://bugzilla.netfilter.org/show_bug.cgi?id=838

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kadlec at netfilter.org

--- Comment #1 from Jozsef Kadlecsik <kadlec at netfilter.org> 2013-08-07 23:54:54 CEST ---
Your patch does not prevent entering other protocols besides TCP and UDP.
That's confusing. because the kernel part handles nothing else. I think a new
function is required which calls ipset_parse_proto_port and then verifies the
protocol.

Also, I think it's unnecessary to add the IPSET_OPT_PROTO flag: this is a
userspace issue and there's no need to send the parsed protocol to the kernel.

Otherwise solution 2 is OK for me.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the netfilter-buglog mailing list