[Bug 713] New: CPPFLAGS are mishandled which breaks non-shared targets

[bugzilla-daemon at bugzilla.netfilter.org]

http://bugzilla.netfilter.org/show_bug.cgi?id=713

           Summary: CPPFLAGS are mishandled which breaks non-shared targets
           Product: iptables
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: unknown
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: vapier at gentoo.org
   Estimated Hours: 0.0


Created an attachment (id=352)
 --> (http://bugzilla.netfilter.org/attachment.cgi?id=352)
0001-clean-up-CPPFLAGS-handling.patch

Currently, cpp flags are put into CFLAGS instead of CPPFLAGS.  Then with
a few specific libraries, some more cpp flags are added into the library
specific CFLAGS.  So at the moment, static-only systems break when the
NO_SHARED_LIBS define is used in files that don't have it explicitly in
the Makefile.

Rather than propagate these flags to the specific files that are failing,
redo the whole thing at the global level.  All the cpp flags are moved
out of AM_CFLAGS and into AM_CPPFLAGS, and NO_SHARED_LIBS is appended to
that variable.  This lets us drop the manual setting of library-specific
CFLAGS in a bunch of places while making sure it shouldn't break again
in the future.

patch attached


-- 
Configure bugmail: http://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.