[Bug 516] New: iptables segfaults when given "" to --log-prefix

[bugzilla-daemon at bugzilla.netfilter.org]

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=516

           Summary: iptables segfaults when given "" to --log-prefix
           Product: iptables
           Version: CVS (please indicate timestamp)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: iptables
        AssignedTo: laforge at netfilter.org
        ReportedBy: vapier at gentoo.org


stupid bug, i know :)

this will trigger a segfault:
# iptables --append LOGDROP --protocol tcp --jump LOG --log-level debug
--log-prefix=""

this is because parse() in the log extensions do:
if (strlen(optarg) != strlen(strtok(optarg, "\n")))

and when you do strtok(""), you get back NULL ... and when you do strlen(NULL),
people get pissed :)

patch attached

-- 
Configure bugmail: https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.