[Bug 466] New: u.tcp used where u.udp should be, in tftp nat helper

[bugzilla-daemon at bugzilla.netfilter.org]

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=466

           Summary: u.tcp used where u.udp should be, in tftp nat helper
           Product: netfilter/iptables
           Version: linux-2.6.x
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: NAT
        AssignedTo: laforge at netfilter.org
        ReportedBy: peter at cs.upt.ro


In net/ipv4/netfilter/ip_nat_tftp.c, in function help():
  exp->saved_proto.udp.port = exp->tuple.dst.u.tcp.port;
Souldn't it be:
  exp->saved_proto.udp.port = exp->tuple.dst.u.udp.port;
?
It works of course, as u is a union and tcp and udp fields are similar.

-- 
Configure bugmail: https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.