ERRATA Re: [PATCH] fix for netfilter/nat/pppoe crashes (hopefully)

Holger Brueckner lists@net-labs.de
Tue, 31 Jul 2001 21:34:40 +0200


hi marc,

thanks for the patch, i hope it works ... but :)

unfortunately i can't apply it. against which kernel version is that patch
?!?
it doesn't work with plain 2.4.7
i tried applying it by hand, but most of the code in 2.4.7 looks completley
different than the reference code in the patch :(

cya

Holger
----- Original Message -----

> Due to a stupid mistake the patch I just posted was an early broken
version
> (some length checks inversed).
>
> Please replace it with the one below.
>
> Sorry about that!
>
> Marc
>
> On Tue, Jul 31, 2001 at 12:42:59PM -0400, Marc Boucher wrote:
> > Hi folks,
> >
> > Enclosed is a patch which should eliminate the crashes involving
> > netfilter/iptables/nat (and often pppoe) that several people have been
> > experiencing under kernels >= 2.4.4.
> >
> > Basically the nat manip_pkt handlers were corrupting
skb_shinfo(skb)->frag_list
> > (thus causing a crash in skb_drop_fraglist()) by stupidly writing beyond
> > skb->end when attempting to update fields (like tcp->check) in truncated
> > inner-ICMP headers.
> >
> > Cheers
> > Marc