[PATCH] re - correction for arch != i386 (PPC)

Christophe Burki christophe.burki@lightning.ch
Thu, 29 Jun 2000 12:06:08 +0200


--------------60B7992767876777E34F2426
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi,

When I try to append a rule for jumping onto a user defined chain,
Netfilter returns me an "invalid argument" error message....

#iptables -N logdrop
#iptables -A FORWARD -j logdrop
#iptables: Invalid argument

It still has  a bug on structures alignement when you initialize the
differents iptables_target structure. This time, it's the standard
target structure...Below is a patch which correct it.

Perhaps, it's a good thing to correct all iptables_target and
iptables_match structures initialization to prevent others bugs. I have
not tested all cases. I do not known if it is a good thing to do that;
what you mean about this Mister Paul Russel??? The following files are
concerned with these modifications:

iptables_target structure:
    extensions/libipt_DNAT.c
    extensions/libipt_LOG.c
    extensions/libipt_MARK.c
    extensions/libipt_MASQUERADE.c
    extensions/libipt_REDIRECT.c
    extensions/libipt_REJECT.c
    extensions/libipt_SNAT.c
    extensions/libipt_standard.c                 already corrected (the
following patch)
    extensions/libipt_TOS.c

iptables_match structure:
    extensions/libipt_limit.c                         already corrected
(previous patch)
    extensions/libipt_mac.c                         already corrected
(previous patch)
    extensions/libipt_mark.c                        already corrected
(previous patch)
    extensions/libipt_multiport.c
    extensions/libipt_owner.c                      already corrected
(previous patch)
    extensions/libipt_state.c                        already corrected
(previous patch)
    extensions/libipt_tos.c                           already corrected
(previous patch)


--- iptables-1.1.0/extensions/libipt_standard.c Wed Apr 19 10:20:59 2000

+++ iptables-1.1.0-patched/extensions/libipt_standard.c Thu Jun 29
10:26:25 2000
@@ -51,8 +51,8 @@
 = { NULL,
     "standard",
     NETFILTER_VERSION,
-    sizeof(int),
-    sizeof(int),
+    IPT_ALIGN(sizeof(int)),
+    IPT_ALIGN(sizeof(int)),
     &help,
     &init,
     &parse,


Best regards
Christophe

PS: excuse my bad english.....

--

Christophe Burki
Software Engineer
Lightning Instrumentation SA

mail: christophe.burki@lightning.ch
web : http://www.lightning.ch


--------------60B7992767876777E34F2426
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit

<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
Hi,

When I try to append a rule for jumping onto a user defined chain, Netfilter returns me an "invalid argument" error message....

#iptables -N logdrop
#iptables -A FORWARD -j logdrop
#iptables: Invalid argument

It still has  a bug on structures alignement when you initialize the differents iptables_target structure. This time, it's the standard target structure...Below is a patch which correct it.

Perhaps, it's a good thing to correct all iptables_target and iptables_match structures initialization to prevent others bugs. I have not tested all cases. I do not known if it is a good thing to do that; what you mean about this Mister Paul Russel??? The following files are concerned with these modifications:

iptables_target structure:
    extensions/libipt_DNAT.c
    extensions/libipt_LOG.c
    extensions/libipt_MARK.c
    extensions/libipt_MASQUERADE.c
    extensions/libipt_REDIRECT.c
    extensions/libipt_REJECT.c
    extensions/libipt_SNAT.c
    extensions/libipt_standard.c                 already corrected (the following patch)
    extensions/libipt_TOS.c

iptables_match structure:
    extensions/libipt_limit.c                         already corrected (previous patch)
    extensions/libipt_mac.c                         already corrected (previous patch)
    extensions/libipt_mark.c                        already corrected (previous patch)
    extensions/libipt_multiport.c
    extensions/libipt_owner.c                      already corrected (previous patch)
    extensions/libipt_state.c                        already corrected (previous patch)
    extensions/libipt_tos.c                           already corrected (previous patch)
 

--- iptables-1.1.0/extensions/libipt_standard.c Wed Apr 19 10:20:59 2000
+++ iptables-1.1.0-patched/extensions/libipt_standard.c Thu Jun 29 10:26:25 2000
@@ -51,8 +51,8 @@
 = { NULL,
     "standard",
     NETFILTER_VERSION,
-    sizeof(int),
-    sizeof(int),
+    IPT_ALIGN(sizeof(int)),
+    IPT_ALIGN(sizeof(int)),
     &help,
     &init,
     &parse,
 

Best regards
Christophe

PS: excuse my bad english.....

--

Christophe Burki
Software Engineer
Lightning Instrumentation SA
mail: christophe.burki@lightning.ch
web : http://www.lightning.ch
  --------------60B7992767876777E34F2426--