module problem memset in 0.1.18

Rusty Russell rusty@linuxcare.com.au
Tue, 29 Feb 2000 16:41:03 +1100


In message <200002271533.JAA02019@kanhere.net> you write:
> Hi
> 	Regarding 'memset' in module ip_conntrack_core.c
> 	It occurs due to this structure init in ip_conntrack_core.c line 776...
> ----------------------------------------------------------------
>    *conntrack = ((struct ip_conntrack)
>                       {{ {{ NULL, NULL }, *tuple, conntrack },
>                          {{ NULL, NULL }, repl_tuple, conntrack },
>                       },
>                        1 << IPS_NORMAL, 0,
>                        ATOMIC_INIT(1), /* home reference. */
>                        { NULL, NULL, jiffies + protocol->expiry,
>                          (unsigned long)conntrack, NULL },

Abhay scores another point: this is it!  Change:

                          (unsigned long)conntrack, NULL },

to

                          (unsigned long)conntrack, NULL, 0 },

Thanks!
Rusty.
--
Hacking time.