iptables.c - printf in exit_help not correct

Kees Bakker kees_bakker@tasking.nl
Thu, 3 Feb 2000 09:04:58 +0100 (MET)


Hi,

In version 0.1.17 of netfilter iptables.c (function exit_printhelp) has
an incorrect printf where it tries to print the usage. There are two
program_name's missing. It becomes quite obvious if you do
 'iptables -h'.

This printf statement is not how I would write it. I would simply repeat
printf and its parameters. 
	printf("       %s -D chain rulenum [options]\n", program_name);
	printf("       %s -[LFZNX] [chain] [options]\n", program_name);
	printf("       %s -P chain target [options]\n", program_name);
It is still readable, and ... it prevents errors when someone wants to add
stuff.
-- 
---------------------------------------------------------------------- 
voice:      +31 33 455 85 84                Tasking Software BV
fax:        +31 33 455 10 05                P.O. Box 899
email:      kees_bakker@tasking.com         3800 AW  Amersfoort
WWW:        http://www.tasking.com          The Netherlands
----------------------------------------------------------------------
     -----  Quality Development Tools Worldwide  -----
            -----------------------------------
English is wonderful, used correctly