[PATCH] libipt_statistic

[Patrick McHardy]

NICOLAS BOULIANE wrote:
> On 7/2/07, Jan Engelhardt <jengelh at computergmbh.de> wrote:
> 
>> >Index: libipt_statistic.c
>> >===================================================================
>> >--- libipt_statistic.c (revision 6898)
>> >+++ libipt_statistic.c (working copy)
>> >@@ -113,6 +113,15 @@
>> >       if (flags & 0x8 && info->mode != XT_STATISTIC_MODE_NTH)
>> >               exit_error(PARAMETER_PROBLEM,
>> >                          "--packet can only be used in nth mode");
>> >+      if ((flags & 0x8) && !(flags & 0x4))
>>
>> This could perhaps be
>>
>>         if ((flags & 0xC) == 0x8)
>>
>>
>>         Jan
>> -- 
>>
> 
> same result, less intuitive. why should I do that ?


Indeed. What would make sense is to use a couple of symbolic
constants for the flag values.