[Patch 1/2] libnfnetlink, iface conversion to string
Eric Leblond
eric at inl.fr
Fri Jan 19 23:46:25 CET 2007
Le vendredi 19 janvier 2007 à 18:38 +0100, Pablo Neira Ayuso a écrit :
> Patrick McHardy wrote:
> > Eric Leblond wrote:
> >> /* rtnl_receive - receive netlink packets from rtnetlink socket */
> >> -int rtnl_receive()
> >> +int rtnl_receive(int rtnl_fd)
> >
> > header file needs to be fixed as well. Is the global rtnl_fd still
> > needed?
>
> Indeed. Eric, all this global stuff below must dissapear at all, from
> rtnl.c:
I totally agree. Patch was prefixed with RFC because I wanted to see if
API was correct. As there is no problem from this point, I will do the
needed cleaning.
All my apologies to Patrick, a bad vimrc and some mistakes make from
previous patch something awful.
> static struct ifindex_map *ifindex_map[16];
To answer to Patrick, I really don't like to have variable and type with
the same name, it's quiet confusing. That's why I change it to "struct
ifindex_map_t".
BR,
--
Eric Leblond <eric at inl.fr>
INL
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message
=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : /pipermail/netfilter-devel/attachments/20070120/97c96a07/attachment.pgp
More information about the netfilter-devel
mailing list