ipt->xt

[Jan Engelhardt]

>> Index: linux-2.6.20-rc5/net/ipv4/netfilter/ipt_LOG.c
>> ===================================================================
>> --- linux-2.6.20-rc5.orig/net/ipv4/netfilter/ipt_LOG.c
>> +++ linux-2.6.20-rc5/net/ipv4/netfilter/ipt_LOG.c
>> @@ -20,12 +20,12 @@
>>  #include <net/route.h>
>>  
>>  #include <linux/netfilter.h>
>> -#include <linux/netfilter_ipv4/ip_tables.h>
>> +#include <linux/netfilter/x_tables.h>
>>  #include <linux/netfilter_ipv4/ipt_LOG.h>
>
>Please keep the _ipv4 entries next to each other.

How do you mean? It looks like this atm:

#include <linux/netfilter.h>
#include <linux/netfilter/x_tables.h>
#include <linux/netfilter_ipv4/ipt_LOG.h>

so, from my point, I'd judge "all the _ipv4 entries" are next to each other
(there is only one after all) -- please elaborate what you intended.
(linux/in.h linux/ip.h?)

>> @@ -471,7 +472,7 @@ static struct nf_logger ipt_log_logger =
>>  
>>  static int __init ipt_log_init(void)
>>  {
>> -	if (ipt_register_target(&ipt_log_reg))
>> +	if (xt_register_target(&ipt_log_reg))
>
>While you're at it, this should return the real error.

Good idea. Separate patch. (There was one more elsewhere.)


	-`J'
--