[PATCH] iptables: ip6table version support and libip6t_multiport.fix

Yasuyuki KOZAKAI yasuyuki.kozakai at toshiba.co.jp
Thu Oct 12 10:11:02 CEST 2006


Hello, sorry for late replying.

From: Rémi Denis-Courmont <rdenis at simphalempin.com>
Date: Tue, 3 Oct 2006 22:58:28 +0300

> Le mardi 3 octobre 2006 17:30, vous avez écrit :
> > IPv4 multiport match (and policy match, too) would help you. It has
> > the line
> >
> > 	#include ../../include/netfilter_ipv4/ipt_multiport.h
> >
> > and definitions for old kernel are included in the header.
> 
> Ok. This time there is no trace of (xt|XT)_ at all:

??? Did you send intended patch ? It includes XT_MULTI_PORTS as folows.

> diff -Nru iptables-1.3.5.orig/extensions/libip6t_multiport.c 
> iptables-1.3.5/extensions/libip6t_multiport.c
> --- iptables-1.3.5.orig/extensions/libip6t_multiport.c	2005-02-19 
> 21:19:17.000000000 +0200
> +++ iptables-1.3.5/extensions/libip6t_multiport.c	2006-08-27 
> 13:03:36.000000000 +0300
> @@ -20,6 +20,23 @@
>  " --dports ...\n"
>  "				match destination port(s)\n"
>  " --ports port[,port,port]\n"

snip

> +	for (i=0; i<XT_MULTI_PORTS; i++)
> +		multiinfo->pflags[i] = 0;
> + 

And I noticed that your mailer breaks the patch. For example, 

> +	printf(" ");
> +}
> +
>  /* Saves the union ip6t_matchinfo in parsable form to stdout. */
>  static void save(const struct ip6t_ip6 *ip, const struct 
> ip6t_entry_match *match)
>  {
> @@ -246,6 +392,41 @@
>  	printf(" ");
>  }

ip6t_entry_match *match) is moved to next line. That should be after
"const struct ".

Regards,

-- Yasuyuki Kozakai





More information about the netfilter-devel mailing list