[NETFILTER 00/09]: Netfilter update

David S. Miller davem at davemloft.net
Tue Mar 21 08:42:55 CET 2006


From: Patrick McHardy <kaber at trash.net>
Date: Tue, 21 Mar 2006 03:18:40 +0100

> Dave, I'm sorry for the annoyance, but please drop the entire patchset
> except for the H.323 helper. Something is messing up ip6tables on
> one of my systems and the only thing I'm sure of is that its not the
> H.323 helper :)
> 
> I'll resubmit the remaining patches once I know whats going on.

Ok, but please kill trailing whitespace in patches, GIT even warns
about this now and you can check and fix it up before applying a patch
by using:

	git apply --check --whitespace=error-all

So, for example, on this H323 patch we get:

+ git apply --check --whitespace=error-all diff
Adds trailing whitespace.
diff:73:	 
Adds trailing whitespace.
diff:146: *  
Adds trailing whitespace.
diff:156: *	 
Adds trailing whitespace.
diff:171: * 	 
Adds trailing whitespace.
diff:5747: *	 
fatal: 5 lines add trailing whitespaces.

I fixed it up by hand this time, but I may stop doing so in
the future and push it back to you instead :-)

Thanks!



More information about the netfilter-devel mailing list