[PATCH] [NETFILTER] nf_conntrack: clean up to reduce size of 'struct nf_conn'

Harald Welte laforge at netfilter.org
Mon Feb 13 09:17:58 CET 2006


On Mon, Feb 13, 2006 at 10:32:49AM +0900, Yasuyuki KOZAKAI wrote:
> 
> Hi, Harald,
> 
> From: Harald Welte <laforge at gnumonks.org>
> Date: Sun, 12 Feb 2006 18:56:22 +0100
> 
> > [NETFILTER] nf_conntrack: clean up to reduce size of 'struct nf_conn'
> > 
> > This patch moves all helper related data fields of 'struct nf_conn' into a
> > separate structure 'struct nf_conn_help'.  This new structure is only
> > present in conntrack entries for which we actually have a helper loaded.
> > 
> > Also, this patch cleans up the nf_conntrack 'features' mechanism to
> > resemble what the original idea was:  Just glue the feature-specific
> > data structures at the end of 'struct nf_conn', and explicitly re-calculate
> > the pointer to it when needed rather than keeping pointers around.
> > 
> > Saves 20 bytes per conntrack on my x86_64 box. A non-helped conntrack is
> > 276 bytes. We still need to save another 20 bytes in order to fit into to
> > target of 256bytes.
> > 
> > Signed-off-by: Harald Welte <laforge at netfilter.org>
> 
> This patch seems not to include fixes I pointed out and you said "fixed".
> Please confirm if you really sent the intended one.

oops, thanks for checking.  Dave: Please hold, I sent an old version.
You'll get a new one ASAP.

-- 
- Harald Welte <laforge at netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/netfilter-devel/attachments/20060213/b6efa51d/attachment.pgp


More information about the netfilter-devel mailing list