[PATCH] Fix expectation mask dumping, take #2

Yasuyuki KOZAKAI yasuyuki.kozakai at toshiba.co.jp
Mon Feb 6 03:15:18 CET 2006


Hi, Pablo,

From: Pablo Neira Ayuso <pablo at netfilter.org>
Date: Mon, 06 Feb 2006 00:54:54 +0100

> Hi,
> 
> @Patrick: this patch fixes the problem that `[NETFILTER 03/14]:
> nf_conntrack: check address family when finding protocol module` works
> around. So I think that such patch needs to be reverted :(

Please don't revert that. I've been thinking that both your and
his patch are necessary. Even if your patch fixes oops triggered by
nfctnetlink, other module might have same problem future.

I think he aim of 2 patches is different. His patch fixes the root
of oops. Your patch fixes dumping expectation mask.

BTW, ah, his patch includes unlikely(). But fortunately,
your patch looks that it makes unnecessary to remove it and
I expect that it will be applied to net-2.6 tree. Great!

-- Yasuyuki Kozakai



More information about the netfilter-devel mailing list