[NETFILTER 2/8]: Add NetBIOS name service helper
Patrick McHardy
kaber at trash.net
Wed Sep 7 05:01:20 CEST 2005
David S. Miller wrote:
> From: Samir Bellabes <sbellabes at mandriva.com>
> Subject: Re: [NETFILTER 2/8]: Add NetBIOS name service helper
> Date: Wed, 07 Sep 2005 04:50:16 +0200
>
>
>>[NETFILTER] Return NF_DROP if expectation failed for Netbios conntrack
>>
>>Fix the returned value when it's not possible to allocate expectation
>>or if ip_conntrack_expect_related() failed.
>>
>>Signed-off-by: Samir Bellabes <sbellabes at mandriva.com>
>
>
> Patrick, I've applied this, I hope you don't mind :)
Actually it was deliberate, I don't see a reason why the packet
should be dropped, its best effort. Besides that the patch
creates a reference leak, we always need to call
ip_conntrack_expect_put. Please revert the patch. Thanks.
More information about the netfilter-devel
mailing list