num_possible_cpus() usage in iptables
David S. Miller
davem at davemloft.net
Tue Oct 11 02:27:28 CEST 2005
From: Eric Dumazet <dada1 at cosmosbay.com>
Date: Mon, 10 Oct 2005 08:23:27 +0200
> My previous patch ([PATCH 3/3] netfilter : 3 patches to boost ip_tables
> performance) addressed this problem.
Long term this is the kind of thing we should be doing.
But for 2.6.14, I would like to suggest that we revert back
to using NR_CPUS as that is the simplest fix for this bug.
I even spent part of this afternoon investigating other kinds of
fixes, and all of them have possible non-trivial regressions.
Yes, using NR_CPUS wastes a lot of ram, but it fixes this
bug in a straightforward and easy to verify fashion.
More information about the netfilter-devel