[PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t)

Krzysztof Oledzki olenf at ans.pl
Fri Nov 25 01:26:20 CET 2005



On Fri, 25 Nov 2005, Pablo Neira wrote:

> Patrick McHardy wrote:
>> Krzysztof Oledzki wrote:
>>
>>> Old binaries are not able to deal with CTA_PROTO and will not be able
>>> to parse this attribute received from kernel. We should keep
>>> CTA_PROTO_NUM here, but this leads to u_int8_t/u_int16_t mismatch in
>>> the code.
>>
>> I didn't notice that, we of course need to dump both attributes. But I
>> still think Pablo's suggestion is fine too and avoids all these hacks.
>> The only people affected will be the ones not using the stable series.
>
> Same feeling. I don't like the idea of breaking backward compatibility,
> but in this case the hacks don't look really nice either :(. Since this
> stuff was just pushed forward to 2.6.14, I still think that we should
> send a patch to fix it in -stable.

But 2.6.14.3 just went out and I'm not sure if there will be another 
2.6.14.x relase.

Best regards,

 				Krzysztof Olędzki


More information about the netfilter-devel mailing list