[PATCH] libnetfilter_queue nfattr[] abstraction

[Harald Welte]

On Fri, Nov 04, 2005 at 01:22:58AM +0100, Eric Leblond wrote:
> Hi,
> 
> This patch is a proposal to suppress the use of struct nfattr* nfa[]
> like params in user level function.

looks fine to me.  I'll rename nfnl_q_datas into nfnl_q_data, though.

> This just hide the low-level structure behind a dummy structure. But
> from a user point of view, this structure should remain inchanged even
> if the kernel internal are changing.

ACK. this can easily be enforced if we put the structure definition into
the C file, and just have a dummy 'struct nfnl_q_data' declaration in
the header.

> I've checked the provided test util and NuFW against the modified
> library.

Please re-check after my changes went in (maybe in 30mins).

-- 
- Harald Welte <laforge at netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/netfilter-devel/attachments/20051105/6caf719d/attachment.pgp