[PATCH] Fix NAT TCP sequence adjustment

Rusty Russell rusty at rustcorp.com.au
Tue May 31 15:48:24 CEST 2005


On Tue, 2005-05-31 at 15:02 +0200, Patrick McHardy wrote:
>  Second of all, I spent like 10 hours to verify the
> proposed fixes, and I am still convinced that it is correct.

Which shows exactly *why* we have a testsuite.  Dammit, I didn't spend
all those hours on it for fun.

You spent *10* hours, and the testsuite runs in 5 seconds (60 seconds
counting build time the first time).

<sigh>

I fixed the testsuite, so now when I get bored I can come up with a
patch which removes those horrible hooks you added (sure, I may have to
rewrite everything to do it).

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman




More information about the netfilter-devel mailing list