skb_ip_make_writable and skbs not owned by a socket

David S. Miller davem at davemloft.net
Thu Jan 27 06:50:39 CET 2005


On Thu, 27 Jan 2005 05:10:42 +0100
Patrick McHardy <kaber at trash.net> wrote:

> Dave, could you please have another look at this ? I think the patch is
> correct, and even necessary to make the ipt action work with targets
> that mangle the data area. Jamal asked me to put back the pskb_expand_head
> call in the ipt action, so iptables won't see cloned skbs and copy them
> (actions must not replace the skb), but the protocol-dependant cases
> in skb_ip_make_writable can cause copying anyway. I think you missed
> my reply to your last mail, please see below.

It's in my backlog, don't worry.  I'll try to get to it tomorrow.

Is it the end of the world if I defer it to 2.6.12?



More information about the netfilter-devel mailing list