[PATCH 4/4] conntrack ftp helper modification to use new infrastrure

Patrick McHardy kaber at trash.net
Mon Jan 10 00:46:41 CET 2005


Pablo Neira wrote:

> Patrick McHardy wrote:
>
>> Why is is part of struct ftpsearch ? One struct nf_string_match per 
>> helper
>> should be enough as long as we take the global lock.
>
>
> because the ftp helper looks for four different patterns. The 
> goodshift and badshift arrays required by the boyer-moore algorithm 
> are different for every pattern.

Thanks for the explanation.

>
> Actually, I started a version using lists of nf_string_match to look 
> for a set of patterns iteratively but I finally decided to simplify 
> the thing. If someone finds this feature interesting I could recover 
> it in future.

Since the FTP helper is currently the only possible user of such a feature
I think the current way is fine.

Regards
Patrick




More information about the netfilter-devel mailing list