[PATCH 9/18] Netfilter: Clean up the kmod handling code in
tgraf at suug.ch
Thu Jan 6 02:30:31 CET 2005
* Rusty Russell <1104973817.20582.110.camel at localhost.localdomain> 2005-01-06 12:10
> On Wed, 2005-01-05 at 19:12 +0100, Thomas Graf wrote:
> > * Rusty Russell <1104896029.20582.72.camel at localhost.localdomain> 2005-01-05 14:33
> > > Name: Clean up the kmod handling code in iptables.c
> > > Status: Tested under nfsim
> > >
> > > 4) Remove __ipt_mutex_up() and __ipt_find_target_lock() which weren't
> > > used (even in patch-o-matic AFAICT).
> > Those are used by ipt action (net/sched/ipt.c).
> > Readds __ipt_find_target_lock() and __ipt_mutex_up() and adapts ipt.c
> > to correctly use it. module must be given back properly upon cleanup.
> > removes the comments demanding for proper module refcnt since
> > find_target_lock() takes care of this now.
> OK, thanks. You missed a module_put in the check_entry-failed error
> path though.
> I looked harder at this, and I prefer this patch:
Looks fine to me.
More information about the netfilter-devel