[PATCH] ctnetlink: Fix NAT info setting.

Marcus Sundberg marcus at ingate.com
Thu Dec 1 14:38:48 CET 2005


Pablo Neira Ayuso wrote:
> Marcus Sundberg wrote:
> 
>>[NETFILTER] ctnetlink: Fix NAT info setting.
>>
>>ip_nat_initialized() takes enum ip_nat_manip_type as it's second
>>argument, not a hook number. The current code was not only ugly,
>>but also broken as IP_NAT_MANIP_SRC != NF_IP_POST_ROUTING.
> 
> Thanks for the bugfix but I don't like it, it's a bit bloated. Harald,
> please submit the patch attached. It uses HOOK2MANIP macro instead.

Ah, I wasn't aware of that macro. I agree that's a nicer fix.

//Marcus
-- 
---------------------------------------+--------------------------
  Marcus Sundberg <marcus at ingate.com>  | Firewalls with SIP & NAT
 Software Developer, Ingate Systems AB |  http://www.ingate.com/



More information about the netfilter-devel mailing list