[PATCH 4/*] libnfnetlink fixes
Harald Welte
laforge at netfilter.org
Sun Aug 28 13:50:13 CEST 2005
On Wed, Jul 13, 2005 at 09:23:56AM +0100, Amin Azez wrote:
> It allows the application-supplied callback handler to signifiy in its
> return code whether or not the nfnl_listen read-loop should terminate.
>
> If the handler returns a negative code, then nfnl_listen returns
> immediately with the same return code.
>
> If the handler returns a postitive code, then nfnl_listen returns at the
> next iteration of the while loop, which is when it finishes handing all
> netlink messages in the current packet.
>
> This avois the need to duplicate most of nfnl_listen in a non-loop
> context where the application needs control over the read and packet
> decode process.
I think this change is fine. Would you mind to re-submit the patch
against current svn? Please also document the meaning of the return
values, probably with a comment in the code or the header file?
Thanks!
--
- Harald Welte <laforge at netfilter.org> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/netfilter-devel/attachments/20050828/9587b7f4/attachment.bin
More information about the netfilter-devel
mailing list