[PATCH] convert mport to multiport
Phil Oester
kernel at linuxace.com
Mon Sep 27 01:27:38 CEST 2004
On Mon, Sep 27, 2004 at 12:55:36AM +0200, Pablo Neira wrote:
> Hi Patrick,
>
> Attached a patch that puts mport and multiport together. It applies to
> latest bk snapshot.
>
> I've also added some clean ups like the use of a count var inside the
> ipt_multiport instead of using 65535 and the pflag set to mark the end
> of the array of ports. I've tested and it works fine for me.
>
> Also attached the patch for iptables and man page. If missing something,
> please let me know.
>
> regards,
> Pablo
Pablo -
first of all, thanks for doing this -- it will come in handy in my scripts.
Minor nit:
@@ -146,6 +161,10 @@
exit_error(PARAMETER_PROBLEM,
"multiport does not support invert");
+ if (invert)
+ exit_error(PARAMETER_PROBLEM,
+ "multiport does not support invert");
+
if (*flags)
exit_error(PARAMETER_PROBLEM,
"multiport can only have one option");
this hunk looks redundant.
Phil
More information about the netfilter-devel
mailing list