[PATCH 2.6 0/12]: netfilter update

David S. Miller davem at redhat.com
Wed Sep 22 02:18:57 CEST 2004


On Wed, 22 Sep 2004 01:38:10 +0200
Patrick McHardy <kaber at trash.net> wrote:

> Done. The updated tree is at the same location.

Thanks, two problems:

1) Please layout the new skbuff.h structure changes more
   intelligently.  Currently the netfilter stuff is:

	pointer
	u32
	pointer
	u32

   and this wastes a lot of space on 64-bitters.

2) There is no way I'm amicable to exporting __tcp_v4_lookup()
   and friends to modules.

   Are you absolutely sure that the existing scheme cannot
   work properly?  I'm talking about relying upon skb->sk
   being sane.

So what I think I'll do is merge in all the changes other
than the ipt_owner.c change by hand into a tree I'll push
to Linus, I'll also fix the layout ordering problem which
I mentioned above in #1

But something has to be done about the ipt_owner.c change, it
isn't going in as-is.



More information about the netfilter-devel mailing list