[PATCH 2/2] Cleanup returnvalues of protocolhandlers

Martin Josefsson gandalf at wlug.westbo.se
Mon Sep 20 11:11:55 CEST 2004


On Sun, 19 Sep 2004, Patrick McHardy wrote:

> Patrick McHardy wrote:
>
> > A couple of conversion where missing in ip_conntrack_proto_icmp.c,
> > I've added them to the patch. BTW: shouldn't we return CONNTRACK_INVALID
> > for all invalid icmp packets ? icmp_error returns CONNTRACK_INVALID for
> > these packets, icmp_error_message (after simple 1:1 conversion) returns
> > CONNTRACK_CONT.
>
> Oops, forgot to attach the new patch.

Bah, that's what you get for mostly hand editing other peoples patches :)

Please ignore this second patch, I'll send you an updated version after
I've gone through it properly and fixed the problems you noticed (and
other possible problems)

Thanks

/Martin



More information about the netfilter-devel mailing list