[PATCH] bug fixes and introducing skb_header_pointer() to ip6t_frag.c

Patrick McHardy kaber at trash.net
Wed Oct 13 08:58:14 CEST 2004


Yasuyuki Kozakai wrote:

>Hi,
>
>The first patch fixes following bugs in ip6t_frag.c,
>
>	- Wrong cast the pointer to extension header.
>	- header length of Fragment Header is statically 8 octets.
>	  Then the option "--frag-len" doesn't make sense.
>	- There are endian issues where using frag->info.
>	- Reserved fields are not 2 bit but 8bit + 2 bit. (see RFC2460)
>
>And the second patch enables ip6t_frag.c to work without skb_linearize().
>
>Before trying these patches, don't forget to apply the patch which prepare
>to removing skb_linearize().
>

Thanks Yasuyuki, your patches all look great. I've applied the
prepare-to-remove-skb_linearize and skb_header_pointer patches
to a post-2.6.9 tree and will push the fixes to Dave immediately.
Just one thing, please sign off your patches next time.

Regards
Patrick




More information about the netfilter-devel mailing list