New draft document on nat / traversal / hole punching (with Dan Kegel)

Rusty Russell rusty at rustcorp.com.au
Thu Nov 11 01:30:56 CET 2004


On Wed, 2004-11-10 at 17:25 +0100, Harald Welte wrote:
> On Wed, Nov 10, 2004 at 10:42:04AM +1100, Rusty Russell wrote:
> > Name: Fix find_appropriate_src() To Actually Work
> > Status: Tested under nfsim
> > Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
> 
> > [...]
> 
> > -			if (newtuple.src.ip != tuple->src.ip)
> > +			if (tuple->src.ip != tuple->src.ip)
> 
> Rusty, are you sure this is really what you want?  ;)

Ew... Dave, please drop that patch as it was crap.

I merged two patches (a cleanup and the fix) and didn't re-test.

I'll fix, test and re-send.

Sorry,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman




More information about the netfilter-devel mailing list