[PATCH 2.4/2.6]: TTL target

[Nicolas Bouliane]

Hi Patrick,

Patrick McHardy wrote:
>
> The kernel-part is fine, the userspace has some minor problems,
> see my comments below. Could you please send a new version ?
>

Sure, thanks for having taken a look.
Your comments was appreciated and instructive.

New patch below.


Signed-off-by: Nicolas Bouliane <nib@cookinglinux.org>


diff -urpN extensions/libipt_TTL.c.orig extensions/libipt_TTL.c
--- extensions/libipt_TTL.c.orig	2004-07-25 21:03:19.000000000 -0400
+++ extensions/libipt_TTL.c	2004-07-25 21:10:45.000000000 -0400
@@ -24,9 +24,9 @@ static void help(void)
 {
 	printf(
 "TTL target v%s options\n"
-"  --ttl-set value		Set TTL to <value>\n"
-"  --ttl-dec value		Decrement TTL by <value>\n"
-"  --ttl-inc value		Increment TTL by <value>\n"
+"  --ttl-set value		Set TTL to <value 0-255>\n"
+"  --ttl-dec value		Decrement TTL by <value 1-255>\n"
+"  --ttl-inc value		Increment TTL by <value 1-255>\n"
 , IPTABLES_VERSION);
 }

@@ -35,7 +35,7 @@ static int parse(int c, char **argv, int
 		struct ipt_entry_target **target)
 {
 	struct ipt_TTL_info *info =3D (struct ipt_TTL_info *) (*target)->data;
-	u_int8_t value;
+	u_int32_t value;

 	if (*flags & IPT_TTL_USED) {
 		exit_error(PARAMETER_PROBLEM,
@@ -50,7 +50,9 @@ static int parse(int c, char **argv, int
 		exit_error(PARAMETER_PROBLEM,
 				"TTL: unexpected `!'");

-	value =3D atoi(optarg);
+	if (string_to_number(optarg, 0, 255, &value) =3D=3D -1)
+      exit_error(PARAMETER_PROBLEM,
+            "TTL: Expected value between 0 and 255");

 	switch (c) {

--
Nicolas Bouliane,
Samuel Jean
at cookinglinux.org