[PATCH] Fix conntrack iteration.
rusty at rustcorp.com.au
Tue Dec 28 02:22:42 CET 2004
On Sat, 2004-12-25 at 15:32 +0100, Patrick McHardy wrote:
> > WRITE_LOCK(&ip_conntrack_lock);
> > - /* Make sure don't leave any orphaned expectations lying around */
> > - if (ct->expecting)
> > - remove_expectations(ct, 1);
> > + BUG_ON(ct->expecting);
> This doesn't look right. The call to remove_expectations was
> added to deal with the TFTP helper registering expectations
> for unconfirmed connections.
Ah, right! I'll add a comment there instead. I couldn't see how it
could happen, but this makes sense.
A bad analogy is like a leaky screwdriver -- Richard Braakman
More information about the netfilter-devel