[PATCH 2.4.x][RFC] enlarge struct ipt_log_info prefix to 62 bytes

Herve Eychenne rv at wallfire.org
Thu Dec 23 02:09:05 CET 2004


On Wed, Dec 22, 2004 at 12:47:17PM +0100, Patrick McHardy wrote:

> Roberto Nibali wrote:

> >Concerning netfilter there is one I think others might "benefit" from as 
> >well. Here's the patch we're using to enlarge the prefix member of the 
> >struct ipt_log_info structure in ipt_LOG.h:
> >
> > struct ipt_log_info {
> >        unsigned char level;
> >        unsigned char logflags;
> >-       char prefix[30];
> >+       char prefix[62];
> > };

> This breaks binary compatibility, so we can't put it in.
> Otherwise I'd agree, 30 byte is kind of small. Maybe it
> will be possible with Rusty's and Pablo's work to extend
> structures without breaking compatibility.

BTW, we really should provide a /proc entry which would give the maximum
length of this LOG prefix.  And while we are at it, another one for
chainname length.  Can somebody think of another useful value which
would be worth publishing?
That will help third party applications a lot, so they can be aware
of how many chars they can use (these values can be changed
at compile time anyhow) and take advantage of it.

 Herve

-- 
 _
(°=  Hervé Eychenne
//)
v_/_ WallFire project:  http://www.wallfire.org/



More information about the netfilter-devel mailing list