[netfilter-core] [2.6 patch] net/ipv4/netfilter/: misc possible cleanups

Harald Welte laforge at netfilter.org
Thu Dec 16 08:40:17 CET 2004


[Removed some Cc's]

On Thu, Dec 16, 2004 at 12:40:48PM +1100, Rusty Russell wrote:
> On Wed, 2004-12-15 at 10:03 +0100, Harald Welte wrote:
> > On Wed, Dec 15, 2004 at 02:19:31AM +0100, Adrian Bunk wrote:
> > > The patch below contains the following possible cleanups:
> ...
> > As you might be aware, netfilter/iptables has an enormously large
> > codebase (I'd say even larger than what is in the tree) in the so-called
> > patch-o-matic subsystem.  The abovementioned exports facilitate those
> > modulse, and A certain amount of those new modules (especially the ones
> > requiring the functions above) are scheduled for mainline inclusion over
> > the next couple of months.
> 
> True, but some of these cleanups are genuine.  Deleting code also
> increases the coverage of the testsuite: I've put this in my patch set
> and will merge them in pieces.  At the rate I work, those that are
> needed in the next few months won't be deleted.  If patches are not due
> to be merged in that timeframe, it'd be nice if they contained the
> exports etc. that they need rather than relying on long-term unused
> features of the tree.

Then different patches need different exports, and you have your patches
again clashing :(  We've been through this...

-- 
- Harald Welte <laforge at netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : /pipermail/netfilter-devel/attachments/20041216/33ed795f/attachment.bin


More information about the netfilter-devel mailing list