[PATCH] l7-filter for pom (2)

Matthew Strait quadong@users.sourceforge.net
Tue Aug 24 02:16:40 CEST 2004


>> - Don't have printk() in per-packet codepath without net_ratelimit() or
>>  you will be DoS'ed
>
> The code should not print anything unless debugging is enabled.  I'm assuming 
> that no one will enable debugging unless they are in a controlled 
> environment.  And when debugging, it would be bad to have most of the 
> messages dropped.  Is this still not ok in your view?

(Replying to self.)  Sorry, I wasn't thinking hard enough.  Obviously, I 
should have rate limits on the error messages, if not the debugging 
messages.

-matthew




More information about the netfilter-devel mailing list