iptables branch, master, updated. v1.4.10-68-g87dc7c4

Patrick McHardy netfilter-cvslog-bounces at lists.netfilter.org
Thu Feb 17 12:00:24 CET 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "iptables".

The branch, master has been updated
       via  87dc7c4c842deb1e2e3d38089ffcad9f238d98de (commit)
      from  e1df221d7a1b3df0224d94865ec05ba336995608 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 87dc7c4c842deb1e2e3d38089ffcad9f238d98de
Author: Max Kellerman <max at duempel.org>
Date:   Thu Feb 17 11:57:19 2011 +0100

    xtables: use strspn() to check if string needs to be quoted
    
    Problem: the call xtables_save_string("'") prints just a single quote,
    not enclosed in double quoted and not escaped.
    
    Steps to reproduce:
    
     $ iptables -A foo -m comment --comment "'" -j ACCEPT
     $ iptables-multi save|grep foo
     -A foo -m comment --comment ' -j ACCEPT
    
    The cause was the use of strcspn() to locate the first character which
    justified quoting the string in double quotes.  That however was
    wrong, because the way strcspn() was called, it returned a pointer to
    the first character that was not to be escaped, which did the right
    thing most of the time, but not for strings consisting only of quote
    characters.  This patch changes strcspn() to strspn().
    
    Signed-off-by: Patrick McHardy <kaber at trash.net>

-----------------------------------------------------------------------

Summary of changes:
 xtables.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
iptables



More information about the netfilter-cvslog mailing list