[iptables] libiptc: avoid strict-aliasing warnings

Harald Welte netfilter-cvslog-bounces at lists.netfilter.org
Sun Oct 25 11:01:19 CET 2009


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=iptables.git;a=commit;h=51651b64fffc58d4f58d005fa7dc0d9669147c57
commit 51651b64fffc58d4f58d005fa7dc0d9669147c57
Author:     Jan Engelhardt <jengelh at medozas.de>
AuthorDate: Fri Oct 23 23:35:49 2009 +0200
Commit:     Harald Welte <laforge at gnumonks.org>
CommitDate: Sun Oct 25 11:01:25 2009 +0100

    libiptc: avoid strict-aliasing warnings
    
    In file included from libiptc/libip4tc.c:117:0:
    libiptc/libiptc.c: In function ‘__iptcc_p_del_policy’:
    libiptc/libiptc.c:826:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libiptc.c: In function ‘iptc_get_target’:
    libiptc/libiptc.c:1650:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libip4tc.c: In function ‘dump_entry’:
    libiptc/libip4tc.c:157:3: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
      CC     libiptc/libip6tc.lo
    In file included from libiptc/libip6tc.c:112:0:
    libiptc/libiptc.c: In function ‘__iptcc_p_del_policy’:
    libiptc/libiptc.c:826:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libiptc.c: In function ‘ip6tc_get_target’:
    libiptc/libiptc.c:1650:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libip6tc.c: In function ‘dump_entry’:
    libiptc/libip6tc.c:188:3: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit a9c79c7ba494b39bad959a0c833e58a343686272
Author:     Jan Engelhardt <jengelh at medozas.de>
AuthorDate: Fri Oct 23 23:40:02 2009 +0200
Commit:     Harald Welte <laforge at gnumonks.org>
CommitDate: Sun Oct 25 11:00:33 2009 +0100

    libiptc: remove unused functions
    
    Fix the two warnings in libiptc.c:
    
      CC     libiptc/libip4tc.lo
    libiptc/libiptc.c:1570:1: warning: ‘iptc_num_rules’ defined but not used
    libiptc/libiptc.c:1586:1: warning: ‘iptc_get_rule’ defined but not used
      CC     libiptc/libip6tc.lo
    libiptc/libiptc.c:1570:1: warning: ‘ip6tc_num_rules’ defined but not used
    libiptc/libiptc.c:1586:1: warning: ‘ip6tc_get_rule’ defined but not used
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit 4a0fbe37a9879ade6a6bf99ab105316284eb4102
Author:     Jan Engelhardt <jengelh at medozas.de>
AuthorDate: Sat Oct 24 01:30:28 2009 +0200
Commit:     Harald Welte <laforge at gnumonks.org>
CommitDate: Sun Oct 25 10:58:52 2009 +0100

    realm: remove static initializations
    
    Save a little disk space, they are initialized to zero anyway.
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>
       via  51651b64fffc58d4f58d005fa7dc0d9669147c57 (commit)
       via  a9c79c7ba494b39bad959a0c833e58a343686272 (commit)
       via  4a0fbe37a9879ade6a6bf99ab105316284eb4102 (commit)
      from  22bdd6966f2c3ccded984a37ba0b97470bcf9323 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 51651b64fffc58d4f58d005fa7dc0d9669147c57
Author: Jan Engelhardt <jengelh at medozas.de>
Date:   Fri Oct 23 23:35:49 2009 +0200

    libiptc: avoid strict-aliasing warnings
    
    In file included from libiptc/libip4tc.c:117:0:
    libiptc/libiptc.c: In function ‘__iptcc_p_del_policy’:
    libiptc/libiptc.c:826:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libiptc.c: In function ‘iptc_get_target’:
    libiptc/libiptc.c:1650:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libip4tc.c: In function ‘dump_entry’:
    libiptc/libip4tc.c:157:3: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
      CC     libiptc/libip6tc.lo
    In file included from libiptc/libip6tc.c:112:0:
    libiptc/libiptc.c: In function ‘__iptcc_p_del_policy’:
    libiptc/libiptc.c:826:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libiptc.c: In function ‘ip6tc_get_target’:
    libiptc/libiptc.c:1650:4: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    libiptc/libip6tc.c: In function ‘dump_entry’:
    libiptc/libip6tc.c:188:3: warning: dereferencing type-punned pointer will break
    strict-aliasing rules
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit a9c79c7ba494b39bad959a0c833e58a343686272
Author: Jan Engelhardt <jengelh at medozas.de>
Date:   Fri Oct 23 23:40:02 2009 +0200

    libiptc: remove unused functions
    
    Fix the two warnings in libiptc.c:
    
      CC     libiptc/libip4tc.lo
    libiptc/libiptc.c:1570:1: warning: ‘iptc_num_rules’ defined but not used
    libiptc/libiptc.c:1586:1: warning: ‘iptc_get_rule’ defined but not used
      CC     libiptc/libip6tc.lo
    libiptc/libiptc.c:1570:1: warning: ‘ip6tc_num_rules’ defined but not used
    libiptc/libiptc.c:1586:1: warning: ‘ip6tc_get_rule’ defined but not used
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit 4a0fbe37a9879ade6a6bf99ab105316284eb4102
Author: Jan Engelhardt <jengelh at medozas.de>
Date:   Sat Oct 24 01:30:28 2009 +0200

    realm: remove static initializations
    
    Save a little disk space, they are initialized to zero anyway.
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

-----------------------------------------------------------------------

 extensions/libipt_realm.c |    5 +--
 libiptc/libip4tc.c        |    3 +-
 libiptc/libip6tc.c        |    3 +-
 libiptc/libiptc.c         |   49 ++++++--------------------------------------
 4 files changed, 13 insertions(+), 47 deletions(-)
Save a little disk space, they are initialized to zero anyway.

Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

diff --git a/extensions/libipt_realm.c b/extensions/libipt_realm.c
index c9e1760..be1943e 100644
--- a/extensions/libipt_realm.c
+++ b/extensions/libipt_realm.c
@@ -35,10 +35,9 @@ struct realmname {
 };
 
 /* array of realms from /etc/iproute2/rt_realms */
-static struct realmname *realms = NULL;
+static struct realmname *realms;
 /* 1 if loading failed */
-static int rdberr = 0;
-
+static int rdberr;
 
 static void load_realms(void)
 {



More information about the netfilter-cvslog mailing list