[conntrack-tools] config: cleanup error reporting during config file parsing

[Pablo Neira]

Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=conntrack-tools.git;a=commit;h=934d6efec6cdaded075b9b2c3de9d245cdb9d686
commit 934d6efec6cdaded075b9b2c3de9d245cdb9d686
Author:     Pablo Neira Ayuso <pablo at netfilter.org>
AuthorDate: Tue Mar 31 21:49:36 2009 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Tue Mar 31 21:49:36 2009 +0200

    config: cleanup error reporting during config file parsing
    
    This patch cleans up the error reporting.
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit c2b5b2dff2eb181044575082d78f0a46bb5986f5
Author:     Pablo Neira Ayuso <pablo at netfilter.org>
AuthorDate: Tue Mar 31 21:09:26 2009 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Tue Mar 31 21:09:26 2009 +0200

    doc: set nice to -20 in example config files
    
    This patch sets the most favourable nice value for conntrackd in the
    default configuration files. This is generally a good idea to reduce
    the chances to hit ENOBUFS.
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>
       via  934d6efec6cdaded075b9b2c3de9d245cdb9d686 (commit)
       via  c2b5b2dff2eb181044575082d78f0a46bb5986f5 (commit)
      from  f133f56f46c5ea52031be986f1a319ead672ef25 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 934d6efec6cdaded075b9b2c3de9d245cdb9d686
Author: Pablo Neira Ayuso <pablo at netfilter.org>
Date:   Tue Mar 31 21:49:36 2009 +0200

    config: cleanup error reporting during config file parsing
    
    This patch cleans up the error reporting.
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit c2b5b2dff2eb181044575082d78f0a46bb5986f5
Author: Pablo Neira Ayuso <pablo at netfilter.org>
Date:   Tue Mar 31 21:09:26 2009 +0200

    doc: set nice to -20 in example config files
    
    This patch sets the most favourable nice value for conntrackd in the
    default configuration files. This is generally a good idea to reduce
    the chances to hit ENOBUFS.
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

-----------------------------------------------------------------------

 doc/sync/alarm/conntrackd.conf   |    8 +-
 doc/sync/ftfw/conntrackd.conf    |    8 +-
 doc/sync/notrack/conntrackd.conf |    8 +-
 src/read_config_yy.y             |  254 +++++++++++++++++++++-----------------
 4 files changed, 158 insertions(+), 120 deletions(-)
This patch sets the most favourable nice value for conntrackd in the
default configuration files. This is generally a good idea to reduce
the chances to hit ENOBUFS.

Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

diff --git a/doc/sync/alarm/conntrackd.conf b/doc/sync/alarm/conntrackd.conf
index 8eb22dd..ca6e661 100644
--- a/doc/sync/alarm/conntrackd.conf
+++ b/doc/sync/alarm/conntrackd.conf
@@ -189,10 +189,12 @@ General {
 	#
 	# Set the nice value of the daemon, this value goes from -20
 	# (most favorable scheduling) to 19 (least favorable). Using a
-	# negative value reduces the chances to lose state-change events.
-	# Default is 0. See man nice(1) for more information.
+	# very low value reduces the chances to lose state-change events.
+	# Default is 0 but this example file sets it to most favourable
+	# scheduling as this is generally a good idea. See man nice(1) for
+	# more information.
 	#
-	Nice -1
+	Nice -20
 
 	#
 	# Number of buckets in the cache hashtable. The bigger it is,
diff --git a/doc/sync/ftfw/conntrackd.conf b/doc/sync/ftfw/conntrackd.conf
index 059f7b3..33c6fce 100644
--- a/doc/sync/ftfw/conntrackd.conf
+++ b/doc/sync/ftfw/conntrackd.conf
@@ -198,10 +198,12 @@ General {
 	#
 	# Set the nice value of the daemon, this value goes from -20
 	# (most favorable scheduling) to 19 (least favorable). Using a
-	# negative value reduces the chances to lose state-change events.
-	# Default is 0. See man nice(1) for more information.
+	# very low value reduces the chances to lose state-change events.
+	# Default is 0 but this example file sets it to most favourable
+	# scheduling as this is generally a good idea. See man nice(1) for
+	# more information.
 	#
-	Nice -1
+	Nice -20
 
 	#
 	# Number of buckets in the cache hashtable. The bigger it is,
diff --git a/doc/sync/notrack/conntrackd.conf b/doc/sync/notrack/conntrackd.conf
index 96ef547..6175284 100644
--- a/doc/sync/notrack/conntrackd.conf
+++ b/doc/sync/notrack/conntrackd.conf
@@ -179,10 +179,12 @@ General {
 	#
 	# Set the nice value of the daemon, this value goes from -20
 	# (most favorable scheduling) to 19 (least favorable). Using a
-	# negative value reduces the chances to lose state-change events.
-	# Default is 0. See man nice(1) for more information.
+	# very low value reduces the chances to lose state-change events.
+	# Default is 0 but this example file sets it to most favourable
+	# scheduling as this is generally a good idea. See man nice(1) for
+	# more information.
 	#
-	Nice -1
+	Nice -20
 
 	#
 	# Number of buckets in the cache hashtable. The bigger it is,