[iptables] build: fix linker issue when LDFLAGS contains --as-needed

Pablo Neira netfilter-cvslog-bounces at lists.netfilter.org
Tue Mar 24 12:32:17 CET 2009


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=iptables.git;a=commit;h=1288bf7e5c39af3ca690a12f419dde507c5a556d
commit 1288bf7e5c39af3ca690a12f419dde507c5a556d
Author:     Peter Volkov <pva at gentoo.org>
AuthorDate: Tue Mar 24 11:09:16 2009 +0300
Commit:     Jan Engelhardt <jengelh at medozas.de>
CommitDate: Tue Mar 24 12:17:09 2009 +0100

    build: fix linker issue when LDFLAGS contains --as-needed
    
    The link of iptables-save fails on:
    
    $ make LDFLAGS="-Wl,--as-needed"
    [...]
    extensions/libext4.a(libxt_RATEEST.o): In function `RATEEST_final_check':
    extensions/libxt_RATEEST.c:164: undefined reference to `log'
    
    Helpful Reference: http://www.gentoo.org/proj/en/qa/asneeded.xml
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit bf02bd290c03fd47b256258e06157f4d9d76e46d
Author:     Jan Engelhardt <jengelh at medozas.de>
AuthorDate: Tue Mar 24 12:13:53 2009 +0100
Commit:     Jan Engelhardt <jengelh at medozas.de>
CommitDate: Tue Mar 24 12:13:53 2009 +0100

    libxt_hashlimit: add missing space for iptables-save output
    
    Reference: http://bugzilla.netfilter.org/show_bug.cgi?id=568
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit 854d2d9bd7556cfd8a676b0bc18dc059a9a2dd25
Author:     Peter Volkov <pva at gentoo.org>
AuthorDate: Tue Mar 24 11:09:16 2009 +0300
Commit:     Jan Engelhardt <jengelh at medozas.de>
CommitDate: Tue Mar 24 12:10:08 2009 +0100

    libxtables: fix compile error due to incomplete change
    
    Commit 2338efd8f799d8373dc196c797bda9690283b698 forgot to update
    the constant in one place, and the compile error triggered only
    when -DNO_SHARED_LIBS (configure --disable-shared) was in effect.
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit ccf3fba1f2a7547d73135bc5499f9e4b1826f758
Author:     Jan Engelhardt <jengelh at medozas.de>
AuthorDate: Thu Mar 19 17:14:49 2009 +0100
Commit:     Jan Engelhardt <jengelh at medozas.de>
CommitDate: Tue Mar 24 12:08:05 2009 +0100

    iptables-save: minor corrections to the manpage markup
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>
       via  1288bf7e5c39af3ca690a12f419dde507c5a556d (commit)
       via  bf02bd290c03fd47b256258e06157f4d9d76e46d (commit)
       via  854d2d9bd7556cfd8a676b0bc18dc059a9a2dd25 (commit)
       via  ccf3fba1f2a7547d73135bc5499f9e4b1826f758 (commit)
      from  c9477d0dcd01af5d1ee6c95c757a8c814fb3be63 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1288bf7e5c39af3ca690a12f419dde507c5a556d
Author: Peter Volkov <pva at gentoo.org>
Date:   Tue Mar 24 11:09:16 2009 +0300

    build: fix linker issue when LDFLAGS contains --as-needed
    
    The link of iptables-save fails on:
    
    $ make LDFLAGS="-Wl,--as-needed"
    [...]
    extensions/libext4.a(libxt_RATEEST.o): In function `RATEEST_final_check':
    extensions/libxt_RATEEST.c:164: undefined reference to `log'
    
    Helpful Reference: http://www.gentoo.org/proj/en/qa/asneeded.xml
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit bf02bd290c03fd47b256258e06157f4d9d76e46d
Author: Jan Engelhardt <jengelh at medozas.de>
Date:   Tue Mar 24 12:13:53 2009 +0100

    libxt_hashlimit: add missing space for iptables-save output
    
    Reference: http://bugzilla.netfilter.org/show_bug.cgi?id=568
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit 854d2d9bd7556cfd8a676b0bc18dc059a9a2dd25
Author: Peter Volkov <pva at gentoo.org>
Date:   Tue Mar 24 11:09:16 2009 +0300

    libxtables: fix compile error due to incomplete change
    
    Commit 2338efd8f799d8373dc196c797bda9690283b698 forgot to update
    the constant in one place, and the compile error triggered only
    when -DNO_SHARED_LIBS (configure --disable-shared) was in effect.
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

commit ccf3fba1f2a7547d73135bc5499f9e4b1826f758
Author: Jan Engelhardt <jengelh at medozas.de>
Date:   Thu Mar 19 17:14:49 2009 +0100

    iptables-save: minor corrections to the manpage markup
    
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

-----------------------------------------------------------------------

 Makefile.am                  |    8 ++++----
 extensions/libxt_hashlimit.c |    2 +-
 ip6tables-save.8             |    9 ++++-----
 iptables-save.8              |    9 ++++-----
 xtables.c                    |    2 +-
 5 files changed, 14 insertions(+), 16 deletions(-)
Signed-off-by: Jan Engelhardt <jengelh at medozas.de>

diff --git a/ip6tables-save.8 b/ip6tables-save.8
index 47eb44a..c760b32 100644
--- a/ip6tables-save.8
+++ b/ip6tables-save.8
@@ -19,10 +19,10 @@
 .\"
 .\"
 .SH NAME
-ip6tables-save \- Save IPv6 Tables
+ip6tables-save - dump iptables rules to stdout
 .SH SYNOPSIS
-.BR "ip6tables-save " "[-M modprobe] [-c] [-t table]"
-.br
+\fBip6tables\-save\fP [\fB\-M\fP \fImodprobe\fP] [\fB\-c\fP]
+[\fB\-t\fP \fItable\fP
 .SH DESCRIPTION
 .PP
 .B ip6tables-save
@@ -36,8 +36,7 @@ inspect /proc/sys/kernel/modprobe to determine the executable's path.
 \fB\-c\fR, \fB\-\-counters\fR
 include the current values of all packet and byte counters in the output
 .TP
-\fB\-t\fR, \fB\-\-table\fR \fBtablename\fR
-.TP
+\fB\-t\fR, \fB\-\-table\fR \fItablename\fP
 restrict output to only one table. If not specified, output includes all
 available tables.
 .SH BUGS
diff --git a/iptables-save.8 b/iptables-save.8
index de5fd48..c1729fe 100644
--- a/iptables-save.8
+++ b/iptables-save.8
@@ -19,10 +19,10 @@
 .\"
 .\"
 .SH NAME
-iptables-save \- Save IP Tables
+iptables-save - dump iptables rules to stdout
 .SH SYNOPSIS
-.BR "iptables-save " "[-M modprobe] [-c] [-t table]"
-.br
+\fBiptables\-save\fP [\fB\-M\fP \fImodprobe\fP] [\fB\-c\fP]
+[\fB\-t\fP \fItable\fP]
 .SH DESCRIPTION
 .PP
 .B iptables-save
@@ -36,8 +36,7 @@ inspect /proc/sys/kernel/modprobe to determine the executable's path.
 \fB\-c\fR, \fB\-\-counters\fR
 include the current values of all packet and byte counters in the output
 .TP
-\fB\-t\fR, \fB\-\-table\fR \fBtablename\fR
-.TP
+\fB\-t\fR, \fB\-\-table\fR \fItablename\fP
 restrict output to only one table. If not specified, output includes all
 available tables.
 .SH BUGS



More information about the netfilter-cvslog mailing list