[libnetfilter_conntrack] api: fix bogus netlink flags in nfexp_build_query

Pablo Neira netfilter-cvslog-bounces at lists.netfilter.org
Sat Nov 29 12:43:57 CET 2008


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=libnetfilter_conntrack.git;a=commit;h=8cf80ddb10752ce66e54378c855e70545d06343e
commit 8cf80ddb10752ce66e54378c855e70545d06343e
Author:     Pablo Neira Ayuso <pablo at netfilter.org>
AuthorDate: Sat Nov 29 12:43:27 2008 +0100
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Sat Nov 29 12:43:27 2008 +0100

    api: fix bogus netlink flags in nfexp_build_query
    
    This patch removes unnecessary flags included in NFCT_Q_DUMP,
    and NFCT_Q_DESTROY requests for expectations.
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>
       via  8cf80ddb10752ce66e54378c855e70545d06343e (commit)
      from  77d597d34e12f7b760e2e58a6d801a28247287bc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8cf80ddb10752ce66e54378c855e70545d06343e
Author: Pablo Neira Ayuso <pablo at netfilter.org>
Date:   Sat Nov 29 12:43:27 2008 +0100

    api: fix bogus netlink flags in nfexp_build_query
    
    This patch removes unnecessary flags included in NFCT_Q_DUMP,
    and NFCT_Q_DESTROY requests for expectations.
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

-----------------------------------------------------------------------

 src/expect/api.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
This patch removes unnecessary flags included in NFCT_Q_DUMP,
and NFCT_Q_DESTROY requests for expectations.

Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

diff --git a/src/expect/api.c b/src/expect/api.c
index bbf6e30..5ed4e4b 100644
--- a/src/expect/api.c
+++ b/src/expect/api.c
@@ -425,13 +425,13 @@ int nfexp_build_query(struct nfnl_subsys_handle *ssh,
 		nfexp_build_expect(ssh, req, size, IPCTNL_MSG_EXP_GET, NLM_F_REQUEST|NLM_F_ACK, data);
 		break;
 	case NFCT_Q_DESTROY:
-		nfexp_build_expect(ssh, req, size, IPCTNL_MSG_EXP_DELETE, NLM_F_ROOT|NLM_F_MATCH|NLM_F_REQUEST|NLM_F_ACK, data);
+		nfexp_build_expect(ssh, req, size, IPCTNL_MSG_EXP_DELETE, NLM_F_REQUEST|NLM_F_ACK, data);
 		break;
 	case NFCT_Q_FLUSH:
 		nfnl_fill_hdr(ssh, &req->nlh, 0, *family, 0, IPCTNL_MSG_EXP_DELETE, NLM_F_REQUEST|NLM_F_ACK);
 		break;
 	case NFCT_Q_DUMP:
-		nfnl_fill_hdr(ssh, &req->nlh, 0, *family, 0, IPCTNL_MSG_EXP_GET, NLM_F_ROOT|NLM_F_MATCH|NLM_F_REQUEST|NLM_F_DUMP);
+		nfnl_fill_hdr(ssh, &req->nlh, 0, *family, 0, IPCTNL_MSG_EXP_GET, NLM_F_REQUEST|NLM_F_DUMP);
 		break;
 	default:
 		errno = ENOTSUP;



More information about the netfilter-cvslog mailing list