[netfilter-cvslog] [conntrack-tools] fix leak in cache_destroy(): release objects before destroying the cache

Pablo Neira netfilter-cvslog-bounces at lists.netfilter.org
Mon May 26 02:44:16 CEST 2008


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=conntrack-tools.git;a=commit;h=5b6627353e2bda89aa506b4573b3fc0d0aa28668
commit 5b6627353e2bda89aa506b4573b3fc0d0aa28668
Author:     Pablo Neira Ayuso <pablo at netfilter.org>
AuthorDate: Mon May 26 02:31:24 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Mon May 26 02:31:24 2008 +0200

    fix leak in cache_destroy(): release objects before destroying the cache
       via  5b6627353e2bda89aa506b4573b3fc0d0aa28668 (commit)
      from  e877faf2c1c557399a57a884a21133e607909b16 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5b6627353e2bda89aa506b4573b3fc0d0aa28668
Author: Pablo Neira Ayuso <pablo at netfilter.org>
Date:   Mon May 26 02:31:24 2008 +0200

    fix leak in cache_destroy(): release objects before destroying the cache

-----------------------------------------------------------------------

 ChangeLog   |    1 +
 src/cache.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 14ba054..2713ac7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -37,6 +37,7 @@ o add missing string.h required by strdup in config parsing
 o add eventfd emulation to communicate receiver -> sender
 o add best effort replication protocol (aka NOTRACK)
 o rework the HELLO logic inside FT-FW
+o fix leak in cache_destroy(): release objects before destroying the cache
 
 version 0.9.6 (2008/03/08)
 ------------------------------
diff --git a/src/cache.c b/src/cache.c
index ed76680..fe5fd27 100644
--- a/src/cache.c
+++ b/src/cache.c
@@ -176,6 +176,7 @@ struct cache *cache_create(const char *name,
 
 void cache_destroy(struct cache *c)
 {
+	cache_flush(c);
 	hashtable_destroy(c->h);
 	free(c->features);
 	free(c->feature_offset);



More information about the netfilter-cvslog mailing list