[iptables] libxt_TOS: make sure --set-tos value/mask is recognized

Patrick McHardy netfilter-cvslog-bounces at lists.netfilter.org
Mon Jun 30 15:10:20 CEST 2008


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=iptables.git;a=commit;h=4ded0f11d382c37a57c04077f453b3978eeded17
commit 4ded0f11d382c37a57c04077f453b3978eeded17
Author:     Jan Engelhardt <jengelh at medozas.de>
AuthorDate: Mon Jun 30 14:57:08 2008 +0200
Commit:     Patrick McHardy <kaber at trash.net>
CommitDate: Mon Jun 30 14:57:08 2008 +0200

    libxt_TOS: make sure --set-tos value/mask is recognized
    
    Only when a 'stop' pointer is passed, the string may consist of more
    than just a number.
    
    Reported-by: Anonymous
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>
    Signed-off-by: Patrick McHardy <kaber at trash.net>
       via  4ded0f11d382c37a57c04077f453b3978eeded17 (commit)
      from  b7580450b4c669846fe840997984dfaaa9c39a71 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4ded0f11d382c37a57c04077f453b3978eeded17
Author: Jan Engelhardt <jengelh at medozas.de>
Date:   Mon Jun 30 14:57:08 2008 +0200

    libxt_TOS: make sure --set-tos value/mask is recognized
    
    Only when a 'stop' pointer is passed, the string may consist of more
    than just a number.
    
    Reported-by: Anonymous
    Signed-off-by: Jan Engelhardt <jengelh at medozas.de>
    Signed-off-by: Patrick McHardy <kaber at trash.net>

-----------------------------------------------------------------------

 extensions/tos_values.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Only when a 'stop' pointer is passed, the string may consist of more
than just a number.

Reported-by: Anonymous
Signed-off-by: Jan Engelhardt <jengelh at medozas.de>
Signed-off-by: Patrick McHardy <kaber at trash.net>

diff --git a/extensions/tos_values.c b/extensions/tos_values.c
index 1630834..4c0b0bc 100644
--- a/extensions/tos_values.c
+++ b/extensions/tos_values.c
@@ -56,8 +56,9 @@ static bool tos_parse_symbolic(const char *str, struct tos_value_mask *tvm,
 {
 	const unsigned int max = 255;
 	const struct tos_symbol_info *symbol;
+	char *tmp;
 
-	if (strtonum(str, NULL, NULL, 0, max))
+	if (strtonum(str, &tmp, NULL, 0, max))
 		return tos_parse_numeric(str, tvm, max);
 
 	/* Do not consider ECN bits */



More information about the netfilter-cvslog mailing list