[ulogd2] Fix crash when using NFCT with hash_enable=0.

Patrick McHardy netfilter-cvslog-bounces at lists.netfilter.org
Wed Jun 4 15:33:59 CEST 2008


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=ulogd2.git;a=commit;h=6396a180f3f15e7417a81b44c61184828268b341
commit 6396a180f3f15e7417a81b44c61184828268b341
Author:     regit <regit at ghlodit.inl.fr>
AuthorDate: Wed Jun 4 15:19:05 2008 +0200
Commit:     Patrick McHardy <kaber at trash.net>
CommitDate: Wed Jun 4 15:19:05 2008 +0200

    Fix crash when using NFCT with hash_enable=0.
    
    This patch fixes NFCT when hash_enable is 0. Limitation of treatment to
    NFCT_DESTROY message type causes usage of the hashtable function and
    hence a crash because it is not initiated.
    
    Signed-off-by: regit <regit at ghlodit.inl.fr>
    Signed-off-by: Patrick McHardy <kaber at trash.net>
       via  6396a180f3f15e7417a81b44c61184828268b341 (commit)
      from  bffb313f5bddf51c086d3250b2b2359c4fe4892e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6396a180f3f15e7417a81b44c61184828268b341
Author: regit <regit at ghlodit.inl.fr>
Date:   Wed Jun 4 15:19:05 2008 +0200

    Fix crash when using NFCT with hash_enable=0.
    
    This patch fixes NFCT when hash_enable is 0. Limitation of treatment to
    NFCT_DESTROY message type causes usage of the hashtable function and
    hence a crash because it is not initiated.
    
    Signed-off-by: regit <regit at ghlodit.inl.fr>
    Signed-off-by: Patrick McHardy <kaber at trash.net>

-----------------------------------------------------------------------

 input/flow/ulogd_inpflow_NFCT.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
This patch fixes NFCT when hash_enable is 0. Limitation of treatment to
NFCT_DESTROY message type causes usage of the hashtable function and
hence a crash because it is not initiated.

Signed-off-by: regit <regit at ghlodit.inl.fr>
Signed-off-by: Patrick McHardy <kaber at trash.net>

diff --git a/input/flow/ulogd_inpflow_NFCT.c b/input/flow/ulogd_inpflow_NFCT.c
index dfb58d5..2a44780 100644
--- a/input/flow/ulogd_inpflow_NFCT.c
+++ b/input/flow/ulogd_inpflow_NFCT.c
@@ -625,7 +625,7 @@ static int event_handler(enum nf_conntrack_msg_type type,
 		.ct = ct,
 	};
 
-	if (!usehash_ce(upi->config_kset).u.value && type == NFCT_T_DESTROY) {
+	if (!usehash_ce(upi->config_kset).u.value) {
 		switch(type) {
 		case NFCT_T_NEW:
 			gettimeofday(&tmp.time[START], NULL);



More information about the netfilter-cvslog mailing list