[libnetfilter_log] Suppress NFULNL_MSG_CONFIG callback registration.

Eric Leblond netfilter-cvslog-bounces at lists.netfilter.org
Tue Dec 30 14:31:05 CET 2008


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=libnetfilter_log.git;a=commit;h=4353e2eeda1f9be2e17cd392180cce6ed0745142
commit 4353e2eeda1f9be2e17cd392180cce6ed0745142
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Mon Dec 29 22:21:57 2008 +0100
Commit:     Eric Leblond <eric at inl.fr>
CommitDate: Tue Dec 30 13:37:14 2008 +0100

    Suppress NFULNL_MSG_CONFIG callback registration.
    
    It seems there is no NFULNL_MSG_CONFIG message send from kernel space to
    userspace. Thus the registration of an nfnetlink callback for this type
    of messages is not necessary.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>

commit a2a235922e04a890d6514d4abff03587a3720eff
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Fri Dec 26 21:39:10 2008 +0100
Commit:     Eric Leblond <eric at inl.fr>
CommitDate: Tue Dec 30 13:36:48 2008 +0100

    Suppress reference to libnetfilter_queue which is the model of libnetfilter_log.
    
    This patch fixes the description of the file was the one of libnetfilter_queue.c
    and it suppresses indication through out the file that it is a copy of the queue
    module.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
       via  4353e2eeda1f9be2e17cd392180cce6ed0745142 (commit)
       via  a2a235922e04a890d6514d4abff03587a3720eff (commit)
      from  9184936c4af8575c29b000da6e0e5be23164f8d1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4353e2eeda1f9be2e17cd392180cce6ed0745142
Author: Eric Leblond <eric at inl.fr>
Date:   Mon Dec 29 22:21:57 2008 +0100

    Suppress NFULNL_MSG_CONFIG callback registration.
    
    It seems there is no NFULNL_MSG_CONFIG message send from kernel space to
    userspace. Thus the registration of an nfnetlink callback for this type
    of messages is not necessary.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>

commit a2a235922e04a890d6514d4abff03587a3720eff
Author: Eric Leblond <eric at inl.fr>
Date:   Fri Dec 26 21:39:10 2008 +0100

    Suppress reference to libnetfilter_queue which is the model of libnetfilter_log.
    
    This patch fixes the description of the file was the one of libnetfilter_queue.c
    and it suppresses indication through out the file that it is a copy of the queue
    module.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>

-----------------------------------------------------------------------

 src/libnetfilter_log.c |   34 +++++++---------------------------
 1 files changed, 7 insertions(+), 27 deletions(-)
This patch fixes the description of the file was the one of libnetfilter_queue.c
and it suppresses indication through out the file that it is a copy of the queue
module.

Signed-off-by: Eric Leblond <eric at inl.fr>

diff --git a/src/libnetfilter_log.c b/src/libnetfilter_log.c
index 216cdb8..ed92561 100644
--- a/src/libnetfilter_log.c
+++ b/src/libnetfilter_log.c
@@ -1,4 +1,4 @@
-/* libnfqnetlink.c: generic library for access to nf_queue
+/* libnetfilter_log.c: generic library for access to NFLOG
  *
  * (C) 2005 by Harald Welte <laforge at gnumonks.org>
  *
@@ -104,7 +104,7 @@ static int __nflog_rcv_cmd(struct nlmsghdr *nlh, struct nfattr *nfa[],
 /* build a NFULNL_MSG_CONFIG message */
 static int
 __build_send_cfg_msg(struct nflog_handle *h, u_int8_t command,
-		     u_int16_t queuenum, u_int8_t pf)
+		     u_int16_t groupnum, u_int8_t pf)
 {
 	union {
 		char buf[NFNL_HEADER_LEN
@@ -113,7 +113,7 @@ __build_send_cfg_msg(struct nflog_handle *h, u_int8_t command,
 	} u;
 	struct nfulnl_msg_config_cmd cmd;
 
-	nfnl_fill_hdr(h->nfnlssh, &u.nmh, 0, pf, queuenum,
+	nfnl_fill_hdr(h->nfnlssh, &u.nmh, 0, pf, groupnum,
 		      NFULNL_MSG_CONFIG, NLM_F_REQUEST|NLM_F_ACK);
 
 	cmd.command = command;
@@ -242,19 +242,19 @@ int nflog_close(struct nflog_handle *h)
 	return ret;
 }
 
-/* bind nf_queue from a specific protocol family */
+/* bind nf_log from a specific protocol family */
 int nflog_bind_pf(struct nflog_handle *h, u_int16_t pf)
 {
 	return __build_send_cfg_msg(h, NFULNL_CFG_CMD_PF_BIND, 0, pf);
 }
 
-/* unbind nf_queue from a specific protocol family */
+/* unbind nf_log from a specific protocol family */
 int nflog_unbind_pf(struct nflog_handle *h, u_int16_t pf)
 {
 	return __build_send_cfg_msg(h, NFULNL_CFG_CMD_PF_UNBIND, 0, pf);
 }
 
-/* bind this socket to a specific queue number */
+/* bind this socket to a specific group number */
 struct nflog_g_handle *
 nflog_bind_group(struct nflog_handle *h, u_int16_t num)
 {
@@ -280,7 +280,7 @@ nflog_bind_group(struct nflog_handle *h, u_int16_t num)
 	return gh;
 }
 
-/* unbind this socket from a specific queue number */
+/* unbind this socket from a specific group number */
 int nflog_unbind_group(struct nflog_g_handle *gh)
 {
 	int ret = __build_send_cfg_msg(gh->h, NFULNL_CFG_CMD_UNBIND, gh->id, 0);



More information about the netfilter-cvslog mailing list