[conntrack-tools] cache_iterators: do not report ENOENT in cache_reset_timers

[Pablo Neira]

Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=conntrack-tools.git;a=commit;h=6ae4b7710c4b8764418a1891902318aa7618044e
commit 6ae4b7710c4b8764418a1891902318aa7618044e
Author:     Pablo Neira Ayuso <pablo at netfilter.org>
AuthorDate: Sat Aug 2 20:07:06 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Sat Aug 2 20:07:06 2008 +0200

    cache_iterators: do not report ENOENT in cache_reset_timers
    
    Do not report ENOENT to log files, this may confuse users. There's a
    race condition when shortening the timers and handling the destroy
    messages. However, this problem is not serious as the point of the
    shortening is to reduce the lifetime of the conntracks. If the conntrack
    is dying, there's no point to shorten their lifetime anymore :)
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>
       via  6ae4b7710c4b8764418a1891902318aa7618044e (commit)
      from  6887cc03a9bc7df031b56ed670fa1db0165d5529 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6ae4b7710c4b8764418a1891902318aa7618044e
Author: Pablo Neira Ayuso <pablo at netfilter.org>
Date:   Sat Aug 2 20:07:06 2008 +0200

    cache_iterators: do not report ENOENT in cache_reset_timers
    
    Do not report ENOENT to log files, this may confuse users. There's a
    race condition when shortening the timers and handling the destroy
    messages. However, this problem is not serious as the point of the
    shortening is to reduce the lifetime of the conntracks. If the conntrack
    is dying, there's no point to shorten their lifetime anymore :)
    
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

-----------------------------------------------------------------------

 src/cache_iterators.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Do not report ENOENT to log files, this may confuse users. There's a
race condition when shortening the timers and handling the destroy
messages. However, this problem is not serious as the point of the
shortening is to reduce the lifetime of the conntracks. If the conntrack
is dying, there's no point to shorten their lifetime anymore :)

Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

diff --git a/src/cache_iterators.c b/src/cache_iterators.c
index 2abb6cd..a7c6654 100644
--- a/src/cache_iterators.c
+++ b/src/cache_iterators.c
@@ -186,7 +186,6 @@ static int do_reset_timers(void *data1, void *data2)
 	ret = nl_exist_conntrack(ct);
 	switch (ret) {
 	case -1:
-	case 0:
 		/* the kernel table is not in sync with internal cache */
 		dlog(LOG_ERR, "reset-timers: %s", strerror(errno));
 		dlog_ct(STATE(log), ct, NFCT_O_PLAIN);