[ulogd2] compilation: set -Wno-ununused-parameter in CFLAGS

Pablo Neira netfilter-cvslog-bounces at lists.netfilter.org
Fri Aug 1 10:32:24 CEST 2008


Gitweb:		http://git.netfilter.org/cgi-bin/gitweb.cgi?p=ulogd2.git;a=commit;h=d8a1b8d30e31b3e06376005f832b71df2eef6399
commit d8a1b8d30e31b3e06376005f832b71df2eef6399
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Fri Aug 1 10:32:13 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Fri Aug 1 10:32:13 2008 +0200

    compilation: set -Wno-ununused-parameter in CFLAGS
    
    This patch adds the "-Wno-unused-parameter" option to CFLAGS. This
    suppress gcc warning that can not be fixed due to the usage of generic system
    like callback where function definition has to be standardized.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 74ad630be147c9f61bf3faee166a415edea4f4fc
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:49:08 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:49:08 2008 +0200

    cleanup: fix warning due to lack of parenthesis
    
    Fix gcc warning related to the lack of parenthesis.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit b28126f76ab0f3a522d2356c11b0909b1d4d48c5
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:47:55 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:47:55 2008 +0200

    cleanup: fix inappropriate initializations in ulogd.c
    
    This patch fixes some improper initialization in ulogd.c.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 6ed31fff112ab5424bd76536eb8e7aaf54c42da9
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:46:56 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:46:56 2008 +0200

    cleanup: fix redefinition of TCP_URG key in printpkt
    
    This patch fixes a multiple definition of the key TCP_URG.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit fe497c497a1a0d018366b1e710b2a176cf9751f7
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:45:27 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:45:27 2008 +0200

    cleanup: fix warning about integer format
    
    This patch uses PRIu64 and PRId64 macros from inttypes.h to have a correct
    definition of 64 bit integer format for 64bits and 32bits arch.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 61704a1f28aad1c64cbcdbec67be17e675482065
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:44:15 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:44:15 2008 +0200

    cleanup: fix compilation warning about lack of parenthesis
    
    This patch adds parenthesis around an expression to avoid confusion
    between order preference of && and || operators.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 1524d689f179eaaae0836ad8ef2da31b10664feb
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:43:08 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:43:08 2008 +0200

    cleanup: fix compilation warnings related to pointer comparisons
    
    This patch cast to (char *) some (void *) to avoid a gcc warning in
    string format parsing.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org

commit 14a8a1e7dd1301002c99598a2b067cde3ca19b6e
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:41:57 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:41:57 2008 +0200

    cleanup: fix compilation warning related to signed and unsigned comparisons
    
    This patch fixes the warning related to signed and unsigned comparaison.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>

commit a52690d2dbb0e14d705ba990cda9b7869a747c0b
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:40:55 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:40:55 2008 +0200

    cleanup: remove unused timeout parameter in function
    
    The function ipulog_read had a timeout parameter which was not
    used in the code.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 507184089236463df25119a4274f4c7dafa60292
Author:     Eric Leblond <eric at inl.fr>
AuthorDate: Thu Jul 31 10:39:31 2008 +0200
Commit:     Pablo Neira Ayuso <pablo at netfilter.org>
CommitDate: Thu Jul 31 10:39:31 2008 +0200

    syslog: cleanly stops syslog
    
    This patch adds a stop function to the module which closes the
    connection to the log system.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>
       via  d8a1b8d30e31b3e06376005f832b71df2eef6399 (commit)
       via  74ad630be147c9f61bf3faee166a415edea4f4fc (commit)
       via  b28126f76ab0f3a522d2356c11b0909b1d4d48c5 (commit)
       via  6ed31fff112ab5424bd76536eb8e7aaf54c42da9 (commit)
       via  fe497c497a1a0d018366b1e710b2a176cf9751f7 (commit)
       via  61704a1f28aad1c64cbcdbec67be17e675482065 (commit)
       via  1524d689f179eaaae0836ad8ef2da31b10664feb (commit)
       via  14a8a1e7dd1301002c99598a2b067cde3ca19b6e (commit)
       via  a52690d2dbb0e14d705ba990cda9b7869a747c0b (commit)
       via  507184089236463df25119a4274f4c7dafa60292 (commit)
      from  445893642e6749fab43c22876893eecabc0e7485 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d8a1b8d30e31b3e06376005f832b71df2eef6399
Author: Eric Leblond <eric at inl.fr>
Date:   Fri Aug 1 10:32:13 2008 +0200

    compilation: set -Wno-ununused-parameter in CFLAGS
    
    This patch adds the "-Wno-unused-parameter" option to CFLAGS. This
    suppress gcc warning that can not be fixed due to the usage of generic system
    like callback where function definition has to be standardized.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 74ad630be147c9f61bf3faee166a415edea4f4fc
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:49:08 2008 +0200

    cleanup: fix warning due to lack of parenthesis
    
    Fix gcc warning related to the lack of parenthesis.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit b28126f76ab0f3a522d2356c11b0909b1d4d48c5
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:47:55 2008 +0200

    cleanup: fix inappropriate initializations in ulogd.c
    
    This patch fixes some improper initialization in ulogd.c.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 6ed31fff112ab5424bd76536eb8e7aaf54c42da9
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:46:56 2008 +0200

    cleanup: fix redefinition of TCP_URG key in printpkt
    
    This patch fixes a multiple definition of the key TCP_URG.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit fe497c497a1a0d018366b1e710b2a176cf9751f7
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:45:27 2008 +0200

    cleanup: fix warning about integer format
    
    This patch uses PRIu64 and PRId64 macros from inttypes.h to have a correct
    definition of 64 bit integer format for 64bits and 32bits arch.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 61704a1f28aad1c64cbcdbec67be17e675482065
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:44:15 2008 +0200

    cleanup: fix compilation warning about lack of parenthesis
    
    This patch adds parenthesis around an expression to avoid confusion
    between order preference of && and || operators.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 1524d689f179eaaae0836ad8ef2da31b10664feb
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:43:08 2008 +0200

    cleanup: fix compilation warnings related to pointer comparisons
    
    This patch cast to (char *) some (void *) to avoid a gcc warning in
    string format parsing.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org

commit 14a8a1e7dd1301002c99598a2b067cde3ca19b6e
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:41:57 2008 +0200

    cleanup: fix compilation warning related to signed and unsigned comparisons
    
    This patch fixes the warning related to signed and unsigned comparaison.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>

commit a52690d2dbb0e14d705ba990cda9b7869a747c0b
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:40:55 2008 +0200

    cleanup: remove unused timeout parameter in function
    
    The function ipulog_read had a timeout parameter which was not
    used in the code.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

commit 507184089236463df25119a4274f4c7dafa60292
Author: Eric Leblond <eric at inl.fr>
Date:   Thu Jul 31 10:39:31 2008 +0200

    syslog: cleanly stops syslog
    
    This patch adds a stop function to the module which closes the
    connection to the log system.
    
    Signed-off-by: Eric Leblond <eric at inl.fr>
    Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

-----------------------------------------------------------------------

 configure.in                              |    2 +-
 filter/raw2packet/ulogd_raw2packet_BASE.c |    2 +-
 filter/ulogd_filter_MARK.c                |    4 ++--
 filter/ulogd_filter_PWSNIFF.c             |    3 ++-
 include/libipulog/libipulog.h             |    2 +-
 input/packet/ulogd_inppkt_ULOG.c          |    2 +-
 libipulog/libipulog.c                     |    4 ++--
 libipulog/ulog_test.c                     |    2 +-
 output/mysql/ulogd_output_MYSQL.c         |    2 +-
 output/pgsql/ulogd_output_PGSQL.c         |    4 ++--
 output/ulogd_output_LOGEMU.c              |    2 +-
 output/ulogd_output_NACCT.c               |    8 ++++----
 output/ulogd_output_SYSLOG.c              |    8 ++++++--
 src/conffile.c                            |    4 ++--
 src/ulogd.c                               |   13 ++++++-------
 util/db.c                                 |   11 ++++++-----
 util/printflow.c                          |    8 ++++----
 util/printpkt.c                           |   13 ++++++-------
 18 files changed, 49 insertions(+), 45 deletions(-)
This patch adds a stop function to the module which closes the
connection to the log system.

Signed-off-by: Eric Leblond <eric at inl.fr>
Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>

diff --git a/output/ulogd_output_SYSLOG.c b/output/ulogd_output_SYSLOG.c
index 8982e7e..8dd93f3 100644
--- a/output/ulogd_output_SYSLOG.c
+++ b/output/ulogd_output_SYSLOG.c
@@ -151,10 +151,13 @@ static int syslog_configure(struct ulogd_pluginstance *pi,
 	return 0;
 }
 
-static void syslog_fini(void)
+static int syslog_fini(struct ulogd_pluginstance *pi)
 {
 	closelog();
+
+	return 0;
 }
+
 static int syslog_start(struct ulogd_pluginstance *pi)
 {
 	openlog("ulogd", LOG_NDELAY|LOG_PID, LOG_DAEMON);
@@ -177,6 +180,7 @@ static struct ulogd_plugin syslog_plugin = {
 	
 	.configure	= &syslog_configure,
 	.start		= &syslog_start,
+	.stop		= &syslog_fini,
 	.interp		= &_output_syslog,
 	.version	= ULOGD_VERSION,
 };



More information about the netfilter-cvslog mailing list